From: David Brownell <[EMAIL PROTECTED]> Date: Wed, 13 Aug 2003 08:30:58 -0700
--- 1.34/drivers/usb/core/message.c Mon Aug 11 07:56:25 2003 +++ edited/drivers/usb/core/message.c Wed Aug 13 08:26:45 2003 - warn("selecting invalid configuration %d", configuration); + dev_dbg(&dev->dev, "selecting invalid configuration %d\n", + configuration);
Are you sure you don't want to leave it printable by default?
Yes. The problem is the caller's; that's where any diagnostics should live. And given usb_reset_configuration(), hardly any code calls usb_set_configuration() ... the remaining call sites behave reasonably here.
Plus, the kernel shouldn't be accumulating lots error message string bloat.
- Dave
------------------------------------------------------- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01 _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
