On Wed, Nov 19 2003, Kai Makisara wrote: > On Wed, 19 Nov 2003, Jens Axboe wrote: > > > On Wed, Nov 19 2003, James Bottomley wrote: > > > > > Alternatively, we could add this as yet another parameter to the host > > > > > and template structures. Any preferences? > > > > > > > > I suppose you have to, if you want LLD to be able to pass it down. > > > > > > Well, what I was fishing for: Is this property useful enough to want > > > every device driver writer to think about it (i.e. document and place in > > > the template), or is it rare enough that it should only be accessible > > > to those who know what they're doing (via the direct block queue > > > interfaces in slave_alloc/configure)? > > > > As far as I'm concerned, requiring 512-byte alignment is 'just > > easier'... Only a select few host adapters will set it differently > > anyways, so you gain basically nothing. > > > As usual, I am against this 512-byte alignment (thinking as st > maintainer). Don't default to more strict aligment requirements than is > necessary. It creates hidden performance problems for character device > drivers.
But you have to honor hardware restrictions, though. Where is the performance impact? -- Jens Axboe ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/ _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
