On Wed, 7 Jul 2004, Alexandre Aractingi wrote:

> So I'm now compiling with your new patches...
> 
> > -                   sdev->request_queue->max_sectors > 128)
> 
> I did not have this line in my original 2.6.7 kernel, so I added the
> changed one (with 64 instead of 128); originally mine looked like:
> 
>         if (us->pusb_dev->descriptor.idVendor == USB_VENDOR_ID_GENESYS
> &&
>                         us->pusb_dev->speed == USB_SPEED_HIGH)
>                 blk_queue_max_sectors(sdev->request_queue, 128);
> 
> 
> and now states:
> 
>         if (us->pusb_dev->descriptor.idVendor == USB_VENDOR_ID_GENESYS
> &&
>                         us->pusb_dev->speed == USB_SPEED_HIGH &&
>                         sdev->request_queue->max_sectors > 64)
>                 blk_queue_max_sectors(sdev->request_queue, 64);
> 
> ...is that still ok?

Yes.  The difference you saw (checking whether max_sectors has already 
been set to a lower value) was a change that evidently didn't get added in 
time to appear in 2.6.7.  What you did is fine.

Alan Stern



-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to