On Tuesday 24 August 2004 4:38 pm, Greg KH wrote:
> On Tue, Aug 24, 2004 at 04:05:17PM -0700, David Brownell wrote:
> > +#ifdef UDC_PROC_FILE
> > +
> > +static const char proc_node_name[] = "driver/udc";
>
> Ick. Please don't do this. Please use sysfs instead. I'll hold of
> applying this for now because of this.
Actually, sysfs unfortunately hasn't yet done right by
that kind of application.
* That 4KB per-file limit (one page?) really makes
trouble when dumping arbitrary-size data structures,
like an N endpoints' request queues.
* What one really wants for that kind of application
is the seq_file logic, which last I heard didn't behave
in the context of sysfs...
That said, Bo's code doesn't use seq_file or dump its
endpoint queues (yet?), so it'd fit fine in a 4K page.
But until seq_file works over sysfs, I'd rather see this
sort of thing stick to the "/proc/driver/udc" convention.
- Dave
-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
