On Tue, Aug 24, 2004 at 05:02:24PM -0700, David Brownell wrote: > On Tuesday 24 August 2004 4:38 pm, Greg KH wrote: > > On Tue, Aug 24, 2004 at 04:05:17PM -0700, David Brownell wrote: > > > +#ifdef UDC_PROC_FILE > > > + > > > +static const char proc_node_name[] = "driver/udc"; > > > > Ick. Please don't do this. Please use sysfs instead. I'll hold of > > applying this for now because of this. > > Actually, sysfs unfortunately hasn't yet done right by > that kind of application. > > * That 4KB per-file limit (one page?) really makes > trouble when dumping arbitrary-size data structures, > like an N endpoints' request queues.
That's because sysfs is a 1 value per file thing. > * What one really wants for that kind of application > is the seq_file logic, which last I heard didn't behave > in the context of sysfs... Exactly. > That said, Bo's code doesn't use seq_file or dump its > endpoint queues (yet?), so it'd fit fine in a 4K page. > > But until seq_file works over sysfs, I'd rather see this > sort of thing stick to the "/proc/driver/udc" convention. Hm, ok. But I'd really like it to be a "DEBUG" option, as that's what it really is. I've gone and applied the patch anyway :) thanks, greg k-h ------------------------------------------------------- SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33 Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift. http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285 _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
