After discussing this patch with Mark Hollomon, I think it is much safer
/ better to leave the conditional check within the while loop. This way
the mutex state is as expected and maintainability is not compromised.
The previous patch should not be applied.
Description: Inserts appropriate set_current_state() call so that
schedule_timeout() functions as expected.
Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]>
Signed-off-by: Maximilian Attems <[EMAIL PROTECTED]>
---
linux-2.6.9-rc1-bk7-max/drivers/usb/media/dabusb.c | 1 +
1 files changed, 1 insertion(+)
diff -puN drivers/usb/media/dabusb.c~set-current-state-drivers_usb_media_dabusb
drivers/usb/media/dabusb.c
---
linux-2.6.9-rc1-bk7/drivers/usb/media/dabusb.c~set-current-state-drivers_usb_media_dabusb
2004-09-01 19:35:55.000000000 +0200
+++ linux-2.6.9-rc1-bk7-max/drivers/usb/media/dabusb.c 2004-09-01 19:35:55.000000000
+0200
@@ -595,6 +595,7 @@ static int dabusb_open (struct inode *in
if (file->f_flags & O_NONBLOCK) {
return -EBUSY;
}
+ set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout (HZ / 2);
if (signal_pending (current)) {
_
-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
