On Wed, Sep 15, 2004 at 05:00:57PM -0400, Alan Stern wrote:
> On Wed, 15 Sep 2004, Greg KH wrote:
> 
> > Ah, nevermind.  See the lkml thread about __iomem for where I was
> > confused.  I'll go fix up the hcd drivers now...
> 
> There's nothing to be done for the UHCI driver, right?  It uses real IO,
> not memory-mapped IO (in{bwl} rather than read{bwl}).

No, there were no __iomem warnings there.  But I did apply the following
patch, fixing up a different sparse warning as long as I was in the area
:)

thanks,

greg k-h

-------


USB: fix up some minor sparse warnings in the uhci driver.
    
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>

diff -Nru a/drivers/usb/host/uhci-hcd.h b/drivers/usb/host/uhci-hcd.h
--- a/drivers/usb/host/uhci-hcd.h       2004-09-15 14:00:56 -07:00
+++ b/drivers/usb/host/uhci-hcd.h       2004-09-15 14:00:56 -07:00
@@ -391,12 +391,12 @@
        struct uhci_qh *qh;             /* QH for this URB */
        struct list_head td_list;       /* P: urb->lock */
 
-       int fsbr : 1;                   /* URB turned on FSBR */
-       int fsbr_timeout : 1;           /* URB timed out on FSBR */
-       int queued : 1;                 /* QH was queued (not linked in) */
-       int short_control_packet : 1;   /* If we get a short packet during */
-                                       /*  a control transfer, retrigger */
-                                       /*  the status phase */
+       unsigned fsbr : 1;              /* URB turned on FSBR */
+       unsigned fsbr_timeout : 1;      /* URB timed out on FSBR */
+       unsigned queued : 1;            /* QH was queued (not linked in) */
+       unsigned short_control_packet : 1;      /* If we get a short packet during */
+                                               /*  a control transfer, retrigger */
+                                               /*  the status phase */
 
        unsigned long inserttime;       /* In jiffies */
        unsigned long fsbrtime;         /* In jiffies */


-------------------------------------------------------
This SF.Net email is sponsored by: thawte's Crypto Challenge Vl
Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam
Camcorder. More prizes in the weekly Lunch Hour Challenge.
Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to