On Wed, Jan 19, 2005 at 02:32:12AM +0100, Thomas Winischhofer wrote:
> >>+ sisusb->sisusb_dev = dev;
> >>+ sisusb->minor = intf->minor;
> >>+ sisusb->fminor = intf->minor - usb_sisusb_class.minor_base;
> >
> >
> >This will not work with CONFIG_USB_DYNAMIC_MINORS enabled, right?
>
>
> OK. How do I find out about
>
> 1) the minor if not from the intf structure? (Or were you only referring
> to the last quoted line?)
The last quoted line, sorry.
> 2) about the number added to the filename? I want that for clear logging.
Rely on udev to give this to you, it's too hard to figure this out from
the kernel properly (but it is possible, see some other drivers for how
they did it.)
> >Mixing tabs and spaces :( Also trailing whitespace.
>
>
> Don't see them here. Done. I see you focus on the important stuff ;)))
I picked off the easy stuff first :)
> >>+/* Structure argument for SISUSB_GET_INFO ioctl */
> >>+typedef struct _SISUSB_INFO sisusb_info, *psisusb_info;
> >
> >No typedefs please.
>
> Why? - Anyway, removed.
See the different reasons in the lkml archives, and in my OLS paper
about the kernel coding rules.
>
> >>+struct _SISUSB_INFO {
> >>+ __u32 sisusb_id; /* for identifying sisusb */
> >>+#ifndef SISUSB_ID
> >>+#define SISUSB_ID 0x53495355 /* Identify myself with 'SISU' */
> >>+#endif
> >
> >
> >What is this for?
>
>
> The userland X driver. And in case some sick mind defines an identical
> ioctl number. sisfb uses the same technique since 2000.
Ah, ok, just curious.
thanks,
greg k-h
-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
