David Brownell wrote:

On Wednesday 19 January 2005 8:03 am, Alan Stern wrote:


On Wed, 19 Jan 2005, Vladimir Trukhin wrote:



--- file_storage.c    2004-12-25 06:36:01.000000000 +0900
+++ file_storage.c    2005-01-14 14:18:51.000000000 +0900
@@ -3714,7 +3714,7 @@
    mod_data.protocol_type = USB_SC_SCSI;
    mod_data.protocol_name = "Transparent SCSI";

-    if (gadget_is_sh(fsg->gadget))
+    if (gadget_is_sh(fsg->gadget) || gadget_is_pxa(fsg->gadget))
        mod_data.can_stall = 0;

if (mod_data.release == 0xffff) { // Parameter wasn't set


You don't need to do this. Just use the 'stall=no' module parameter when the driver is loaded.



Though if it's confirmed that this is a hardware bug -- very possible
with that chip! -- then that's the right patch. Though from what I've
seen so far, I'd not rule out a bug in pxa2xx_udc. I forget the details;
was this with the 2.6.10 code?



Right, kernel 2.6.10.


Best regards, Vlad Trukhin



-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to