On Mon, 7 Feb 2005, David Brownell wrote: > > Something else has come up. In that dev_info() message in usb_add_hcd(), > > where it prints out the iomem or iobase value... For the memory-mapped > > I/O case, does it make more sense to print the original I/O address or the > > value of the mapped memory pointer? The former seems more meaningful to > > me, but almost all the drivers do the latter. Wasn't there some > > discussion about this earlier? I can't recall the outcome... > > Print out the hardware address; match /proc/iomem. There was a patch > submitted to make that happen, maybe it got lost somewhere.
Okay. ohci-omap.c doesn't ever call ioremap(); it simply does readl/writel to the resource address. Is this correct? It leads to a compiler warning when converting the u64 resource[0].start to (void __iomem *) hcd->regs (cast to pointer from integer of different size). Should I stick in an intermediate cast to u32? Alan Stern ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
