On Fri, Feb 18, 2005 at 02:24:44PM -0500, Dan Streetman wrote: > > Ok, so I think that all are in agreement that this patch is ok. This > allows people to use hw-calibration. This should not effect people using > software calibration at all (besides having to do a one-time > software recalibration). > > Signed-off-by: Dan Streetman <[EMAIL PROTECTED]>
This will break setups where someone is using a non-calibrated touchscreen with the current driver, right? I don't think I can merge it at least until there is a way to set the hardware calibration to sane values. > --- linux-2.6.11-rc4-orig/drivers/usb/input/mtouchusb.c 2005-02-18 > 13:35:51.000000000 -0500 > +++ linux-2.6.11-rc4/drivers/usb/input/mtouchusb.c 2005-02-18 > 13:41:02.000000000 -0500 > @@ -52,11 +52,11 @@ > #include <linux/usb.h> > > #define MTOUCHUSB_MIN_XC 0x0 > -#define MTOUCHUSB_MAX_XC 0x4000 > +#define MTOUCHUSB_MAX_XC 0xffff > #define MTOUCHUSB_XC_FUZZ 0x0 > #define MTOUCHUSB_XC_FLAT 0x0 > #define MTOUCHUSB_MIN_YC 0x0 > -#define MTOUCHUSB_MAX_YC 0x4000 > +#define MTOUCHUSB_MAX_YC 0xffff > #define MTOUCHUSB_YC_FUZZ 0x0 > #define MTOUCHUSB_YC_FLAT 0x0 > > @@ -65,8 +65,8 @@ > #define MTOUCHUSB_REPORT_DATA_SIZE 11 > #define MTOUCHUSB_REQ_CTRLLR_ID 10 > > -#define MTOUCHUSB_GET_XC(data) (data[8]<<8 | data[7]) > -#define MTOUCHUSB_GET_YC(data) (data[10]<<8 | data[9]) > +#define MTOUCHUSB_GET_XC(data) (data[4]<<8 | data[3]) > +#define MTOUCHUSB_GET_YC(data) (data[6]<<8 | data[5]) > #define MTOUCHUSB_GET_TOUCHED(data) ((data[2] & 0x40) ? 1:0) > > #define DRIVER_VERSION "v1.4" > -- Vojtech Pavlik SuSE Labs, SuSE CR ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
