randy_dunlap wrote:
On Sat, 4 Jun 2005 10:50:57 +0300 Kiril Jovchev wrote:
| On 6/3/05, Greg KH <[EMAIL PROTECTED]> wrote:
| > On Fri, Jun 03, 2005 at 03:37:01PM +0300, Kiril Jovchev wrote:
| >
| > Please read Documentation/Submitting patches for how to do this
| > properly. Your patch was linewrapped, and you didn't have a good
| Using Gmail to send was not probably a good idea.
|
| > changelog entry, and no Signed-off-by: line :(
Well I am resubmitting the patch I hope that this time I get it right.
I have fixed the line wrapping problem.
Added changelog in the e-mail body and removed it from the patch.
Changelog:
Added support for Creative WebCam Go Mini.
Camera has STV680 chip and just different Product ID(0x4007) and Vendor ID
(0x041e).
So here is the patch:
Signed-off-by: Kiril Jovchev <[EMAIL PROTECTED]>
---
--- linux-2.6.11.11/drivers/usb/media/stv680.c 2005-05-27 08:06:46.000000000
+0300
+++ linux/drivers/usb/media/stv680.c 2005-06-04 21:09:02.000000000 +0300
@@ -1375,9 +1375,13 @@ static int stv680_probe (struct usb_inte
(le16_to_cpu(dev->descriptor.idProduct) == USB_PENCAM_PRODUCT_ID)) {
camera_name = "STV0680";
PDEBUG (0, "STV(i): STV0680 camera found.");
+ } else if ((le16_to_cpu(dev->descriptor.idVendor) ==
USB_CREATIVEGOMINI_VENDOR_ID) &&
+ (le16_to_cpu(dev->descriptor.idProduct) ==
USB_CREATIVEGOMINI_PRODUCT_ID)) {
+ camera_name = "Creative WebCam Go Mini";
+ PDEBUG (0, "STV(i): Creative WebCam Go Mini found.");
} else {
- PDEBUG (0, "STV(e): Vendor/Product ID do not match STV0680
values.");
- PDEBUG (0, "STV(e): Check that the STV0680 camera is connected to
the computer.");
+ PDEBUG (0, "STV(e): Vendor/Product ID do not match STV0680 or
Creative WebCam Go Mini values.");
+ PDEBUG (0, "STV(e): Check that the STV0680 or Creative WebCam Go
Mini camera is connected to the computer.");
retval = -ENODEV;
goto error;
}
--- linux-2.6.11.11/drivers/usb/media/stv680.h 2005-05-27 08:06:46.000000000
+0300
+++ linux/drivers/usb/media/stv680.h 2005-06-03 13:36:57.000000000 +0300
@@ -41,12 +41,17 @@
#define USB_PENCAM_VENDOR_ID 0x0553
#define USB_PENCAM_PRODUCT_ID 0x0202
+
+#define USB_CREATIVEGOMINI_VENDOR_ID 0x041e
+#define USB_CREATIVEGOMINI_PRODUCT_ID 0x4007
+
#define PENCAM_TIMEOUT 1000
/* fmt 4 */
#define STV_VIDEO_PALETTE VIDEO_PALETTE_RGB24
static struct usb_device_id device_table[] = {
{USB_DEVICE (USB_PENCAM_VENDOR_ID, USB_PENCAM_PRODUCT_ID)},
+ {USB_DEVICE (USB_CREATIVEGOMINI_VENDOR_ID,
USB_CREATIVEGOMINI_PRODUCT_ID)},
{}
};
MODULE_DEVICE_TABLE (usb, device_table);
-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games. How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy.
Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
