On Fri, 15 Jul 2005 13:16:58 -0400, Nick Sillik <[EMAIL PROTECTED]> wrote:

The kcalloc with a constant 1 argument is exceedingly fishy. Too bad
I did not pay attention when someone proposed it. On the other hand,
I never have time for good flamewars these days...

> +     interface = ss->pusb_intf->cur_altsetting;
> +
> +     endpoint = &interface->endpoint[2].desc;
> +     if(!(endpoint->bEndpointAddress & 0x80))
> +             return -ENODEV;
> +     if((endpoint->bmAttributes & 3) != 3)
> +             return -ENODEV;

It's sad that this cannot be bound to a driver outside of usb-storage.

BTW, I have an even stranger case: a media reader with a button which
does not have an interrupt endpoint. Behold:

T:  Bus=01 Lev=01 Prnt=01 Port=02 Cnt=01 Dev#=  8 Spd=480 MxCh= 0
D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
P:  Vendor=0781 ProdID=8989 Rev= 0.01
S:  Manufacturer=SanDisk
S:  Product=ImageMate 12 in 1 Reader/Writer
S:  SerialNumber=0300118916
C:* #Ifs= 1 Cfg#= 1 Atr=80 MxPwr=500mA
I:  If#= 0 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=ub
E:  Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E:  Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms

-- Pete


-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to