On Tue, 2005-08-23 at 12:43 +0200, Bernd Petrovitsch wrote:
> Just C-specific ones - God knows what people will pass as argument:
> 
> > +#ifdef CONFIG_PXA27x
> > +#define OHCI_GETPORTNUM(x) ((x & RH_A_NDP) + 1)
> +#define OHCI_GETPORTNUM(x)   (((x) & RH_A_NDP) + 1)
> > +#else
> > +#define OHCI_GETPORTNUM(x) (x & RH_A_NDP)
> +#define OHCI_GETPORTNUM(x)     ((x) & RH_A_NDP)
> > +#endif

Thanks. I also noticed:

> -       ndp = (temp & RH_A_NDP);
> +       ndp = OHCI_GETPORTNUM(temp & RH_A_NDP);

which should have been:

+       ndp = OHCI_GETPORTNUM(temp);

Richard



-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to