Am Sonntag, 8. Januar 2006 00:21 schrieb Pete Zaitcev:
> On Sat, 07 Jan 2006 23:11:07 +0000, Alan Cox <[EMAIL PROTECTED]> wrote:
> 
> >         wait_event(tty_ldisc_wait, tty_ldisc_try(tty));
> 
> That is more or less all right, I agree. It is still somewhat limited
> because the lock cannot be held across the loop into its body, so
> actions cannot be taken atomically with the condition.
> 
> Most of the people do what Oliver did though... Oddly enough, we do
> not make any actions in that loop in usblp.c, so it could have been
> a function which locked around ->wcomplete and ->rcomplete.
> I plotted to bracket them properly for a long time. I bet printing
> with preempt enabled is an adventure.

Upon second thought, it seems like the driver is not thread safe.
However, it never was. I'll make an additional patch.

        Regards
                Oliver


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to