On Friday 27 January 2006 2:19 pm, Micah Dowty wrote:
> The usbfs code path for submitting Isochronous URBs still limits
> each packet to 1k. This may have been appropriate for USB 1.1, but
> high-speed devices sending multiple physical packets per microframe
> may require a much larger "packet" size. This increases the limit
> to 6144, sufficient for three 2k packets per microframe.

But the USB limit is that each ISO endpoint may only
have at most three 1KB packets ... and even that, only
for high speed devices in a releant altsetting.

So this patch is incorrect.

> Signed-off-by: Micah Dowty <[EMAIL PROTECTED]>
> 
> --- .pc/usbiso-1k-limit/drivers/usb/core/devio.c      2006-01-27 
> 14:03:56.000000000 -0800
> +++ drivers/usb/core/devio.c  2006-01-27 14:03:58.000000000 -0800
> @@ -928,7 +928,11 @@
>                       return -EFAULT;
>               }
>               for (totlen = u = 0; u < uurb->number_of_packets; u++) {
> -                     if (isopkt[u].length > 1023) {
> +                     /*
> +                      * Must be big enough for the largest possible packet 
> with mult=2,
> +                      * in order to support high-bandwidth USB2 modes.
> +                      */
> +                     if (isopkt[u].length > 6144) {
>                               kfree(isopkt);
>                               return -EINVAL;
>                       }
> 
> 


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to