Pete Zaitcev wrote: > On Sat, 29 Apr 2006 17:49:40 -0700, Phil Dibowitz <[EMAIL PROTECTED]> wrote: > >>> Why just certain entries? Why not everything? >>> >>> It seems inconsistent (and an invitation for a zillion little patches) to >>> only apply this to a select few devices which Pete happens to have. >> I agree - I have no objection to adding this extra arguement to all of >> UNUSUAL_DEVs. > > I think that you are right, it's cleaner. But the size of this thing > is intimidating. Please see attached...
Heh. I have faith in you, Pete. =) So what criteria did you use to decide whether to set it to USB_US_TYPE_STOR or "0"? I'm assuming 0 means usb-storage? Maybe I'm just tired, but I don't see the code that uses this to make a decision on which driver to use here in the patch... Other than that, after a quick pass over it, it seems a lot cleaner. I'll look more deeply and provide more feedback if needed when I get some time. -- Phil Dibowitz [EMAIL PROTECTED] Freeware and Technical Pages Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Suess
signature.asc
Description: OpenPGP digital signature
