Hi Sergei,

On Wed, 07 Jun 2006 21:54:16 +0400
Sergei Organov <[EMAIL PROTECTED]> wrote:

| Would it be a welcome contribution if I try to split the "generic" into,
| say, usb-serial-core and usb-serial-generic, the latter being really
| tiny at the beginning, and then improve it for speed? I've actually done
| it (speed improvement for bulk transfers) one time for 2.4.x, but at
| that time interface to the tty layer was not suitable for high-speed
| transfers and therefore my code had quite a few ugly kludges and finally
| I wasn't able to match raw USB bulk speeds anyway. Now, AFAIK, the tty
| layer interface has been improved and I hope to have better experience.

 Yes, it was.

 Considering the current design, one thing I'd like to have is the generic
code completely decoupled from the usbserial module, ie, a real
usbserial-generic module.

 This would also force us to kill the fix_up_generic() function.
I don't like the way it works, IMHO, it's C black magic, and it
can lead to trouble.

 Would be better to have usbserial-generic only exporting the
generic methods, then driver authors would assign by hand the methods
he (or she) wants to use (yes, nothing automatic).

 I said 'current design' because the generic code could be merged
with usbserial core with the libata-like design we discussed
some days ago (which is part of my Serial Core port WIP[1]).

[1] 
http://distro2.conectiva.com.br/~lcapitulino/patches/usbserial/2.6.17-rc5/serialcore-port-V0/

-- 
Luiz Fernando N. Capitulino


_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to