On Tue, Jul 11, 2006 at 11:04:16PM -0700, Phil Dibowitz wrote: > Greg KH wrote: > >>> Your email client wrapped the patch :( > >>> > >>> Also, don't InterCap the file name, this should just be called > >>> "aircable.c". > >> This was my error, filename is too long, I will use the name you > >> suggested. I'm using Mozilla Thunderbird, which email client do you > >> suggest for sending patches?. > > > > I like mutt. > > I use a combination of mutt and tbird... but mutt doesn't control this since > it allows you to use any editor you want, and I use vim.. and in vim I have > textwidth set to 78 characters per standard netiquette (which says you > should wrap to < 80 chars). Thus if I sent in-line patches in mutt, they'd > be wrapped.
Not true at all, I use mutt, and vim, and from within vim, import patches directly all the time. Use the ":r" command to read in the patch file to the mail message. > This is why I attach my patches to my email. While according to various FAQs > this is discouraged, neither this list nor the netdev list (which complains > about darn near everything) has complained. Well, I put up with your attachments, as it isn't that hard to edit it by hand :) > The benefit with attaching them > is that you can follow good practice and wrap your emails, but leave your > patches unmodified, and it's easy for someone to drop that patch into a > directory without having to cut and paste. Additionally, it's consistent > regardless of what MUA I choose to use from webmail (IMP), gui MUA > (thunderbird), or cli MUA (mutt). > > Of course, I'm not you Greg, and you take in the patches, but you never seem > to mind... so jump in here if you're thinking "Gah, I HATE Phil for that!" ;) Heh. The only thing that really bugs me is when I get signed patches, like you send. That requires me to run the message through either a de-mimer program I have, or just hand edit the raw email message. Which is a pain at times, as it stops the flow of importing patches, but so far I've lived with it, as it isn't _that_ annoying :) thanks, greg k-h ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel