On Tue, Jul 11, 2006 at 11:49:05PM -0700, Phil Dibowitz wrote:
> Greg KH wrote:
> > Not true at all, I use mutt, and vim, and from within vim, import
> > patches directly all the time.  Use the ":r" command to read in the
> > patch file to the mail message.
> 
> True. copy and paste won't work though.

There's an x program that will properly handle tabs and such I think.
Then use it and do a ":set paste" before pasting it and everything
should be fine.

> > Heh.  The only thing that really bugs me is when I get signed patches,
> > like you send.  That requires me to run the message through either a
> > de-mimer program I have, or just hand edit the raw email message.
> > 
> > Which is a pain at times, as it stops the flow of importing patches, but
> > so far I've lived with it, as it isn't _that_ annoying :)
> 
> Wait... you use mutt which has PGP/Mime support... it should automatically
> fix this for for you... just save the extension you want to the place you
> want. Right arrow -> (vi directional keys to choose right attachement) ->
> "s". This is one of many reasons mutt rules - native PGP/Mime support.
> 
> Or am I misunderstanding your workflow?

Yes.  Here's how I work.

After getting the emails into a mbox that I want to apply, I run a macro
from within mutt that is defined as:
        macro index H |'/home/greg/linux/x.sh'\n

x.sh can be seen at:
        
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/scripts/x.sh
if you're curious.  It takes the patch, strips off dos line feeds, mbox
headers I don't need, and then drops me into the editor so I can touch
it up for anything that I need to do by hand (add signed-off-by, fix the
Subject to be sane, and so on.)  Then it imports the patch into quilt
and refreshes it to look proper.

If you can tell me how to modify this workflow to strip off the pgp/mime
stuff, I'd really appreciate it (remember, I need to work on the whole
email, I need those headers, as git later wants them for date and author
information, as well as the description for the patch.)

> NOTE: What follows is an interesting observation and thought... NOT an
> invitation for people to start an argument about whether people should sign
> patches.
> 
> <observation>
> When Linus designed his Signed-off-by system, he'd originally talked about
> using PGP, but had a few reasons he chose not to... as I recall, one of them
> was, if your going to use PGP as a method of tracking and validation, which
> is great, you gotta store that somewhere, and writing something to track all
> that was a lot more work then just adding a Signed-off-by line. But I think
> it woulda been cool. It's nice to know that no one can send a patch that
> gets attributed to me that I didn't write.
> </observation>

Signed-off-by: is pretty much used as a "path of blame" for when
something goes wrong.  So it would be hard to add multiple signatures to
a patch to show this up in a simple manner.

thanks,

greg k-h


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to