On 7/29/06, Pete Zaitcev <[EMAIL PROTECTED]> wrote:
> On Fri, 28 Jul 2006 10:25:32 -0300, "Thiago Galesi" <[EMAIL PROTECTED]> wrote:
>
> > Fixes several lines that overrun 80 columns in Prolific pl2303 driver
>
> > - usb_serial_debug_data(debug, &port->dev, __FUNCTION__, count,
> > port->write_urb->transfer_buffer);
> > + usb_serial_debug_data(debug, &port->dev, __FUNCTION__, count
> > + , port->write_urb->transfer_buffer);
>
> Are you out of your mind?
Sigh. Different editors show this differently. vi here shows ", port"
aligned with "(debug". Yes, this is not correct.
>
> > -static void pl2303_set_termios (struct usb_serial_port *port, struct
> > termios *old_termios)
> > +static void pl2303_set_termios (struct usb_serial_port *port, struct
> > termios
> > + *old_termios)
> > {
>
> Ditto.
>
Ditto. old_termios was supposed to be under termios in "struct termios".
> > @@ -378,8 +382,10 @@ static void pl2303_set_termios (struct u
> > cflag = port->tty->termios->c_cflag;
> > /* check that they really want us to change something */
> > if (old_termios) {
> > +
> > if ((cflag == old_termios->c_cflag) &&
> > - (RELEVANT_IFLAG(port->tty->termios->c_iflag) ==
> > RELEVANT_IFLAG(old_termios->c_iflag))) {
> > + (RELEVANT_IFLAG(port->tty->termios->c_iflag) ==
> > + RELEVANT_IFLAG(old_termios->c_iflag))) {
>
> NO.
Ok, how should it be done then? "(RELEVANT" and "RELEVANT" aligned
with "((cflag"?
>And what's up with this extra empty line?
Easier to read? That part does not look good without the extra line
when the patch is applied.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
