Jacek Pliszka wrote:
>
> On Wed, 13 Mar 2002, Tero Manninen wrote:
>
> > The diffs between 0.1 and 0.2 aren't that big (one buffer size changed
> > and US_PR_CB changed to US_PR_CBI. I doubt that it would make a
> > difference. I'll make an update anyway. Thanks :-)
>
> Well, I know it helped me and a few other folks.
And it did the trick for me too :-)
I was positively surprized, since there weren't too many changes between
0.1 and 0.2.
The way I made it:
1) Copied fresh 2.4.18 drivers/usb directory hierarchy on top of my
build tree.
2) Applied the version 0.2 mcrw patch
3) Added manually changes in *.rej files
4) Tried compilation
5) Further corrections to get the gcc errors & warnings away:
- two places where gcc reported that "result" could be used as
uninitizlied (so I assigned
default value of USB_STOR_TRANSPORT_ERROR in the declarations)
- two references to function clear_halt() changed to usb_clear_halt()
- static int mcr_init() -> took away static since declared that way
in mcrw.h and the function is anyway used in another C module (in usb.c
by #include of unusual_devs.h)
Here's the context diff to my changes in mcrw.c:
=== BEGIN OF DIFF ===
*** mcrw.c_02 Wed Mar 13 20:51:42 2002
--- mcrw.c Wed Mar 13 21:19:53 2002
***************
*** 192,198 ****
unsigned char *data,
int use_sg) {
! int result;
struct vendorCardInfo *info = (struct vendorCardInfo
*)us->extra;
struct scatterlist *sg = NULL;
int i;
--- 192,198 ----
unsigned char *data,
int use_sg) {
! int result = USB_STOR_TRANSPORT_ERROR;
struct vendorCardInfo *info = (struct vendorCardInfo
*)us->extra;
struct scatterlist *sg = NULL;
int i;
***************
*** 234,240 ****
unsigned char *data,
int use_sg) {
! int result;
struct vendorCardInfo *info = (struct vendorCardInfo
*)us->extra;
struct scatterlist *sg = NULL;
int i;
--- 234,240 ----
unsigned char *data,
int use_sg) {
! int result = USB_STOR_TRANSPORT_ERROR;
struct vendorCardInfo *info = (struct vendorCardInfo
*)us->extra;
struct scatterlist *sg = NULL;
int i;
***************
*** 918,934 ****
set_current_state(TASK_RUNNING);
US_DEBUGP("CB_reset: clearing endpoint halt\n");
! clear_halt(us->pusb_dev,
! usb_rcvbulkpipe(us->pusb_dev, us->ep_in));
! clear_halt(us->pusb_dev,
! usb_rcvbulkpipe(us->pusb_dev, us->ep_out));
US_DEBUGP("CB_reset done\n");
/* return a result code based on the result of the control
message */
return SUCCESS;
}
! static int mcr_init(struct us_data *us) {
int result;
int pipe;
--- 918,934 ----
set_current_state(TASK_RUNNING);
US_DEBUGP("CB_reset: clearing endpoint halt\n");
! usb_clear_halt(us->pusb_dev,
! usb_rcvbulkpipe(us->pusb_dev, us->ep_in));
! usb_clear_halt(us->pusb_dev,
! usb_rcvbulkpipe(us->pusb_dev, us->ep_out));
US_DEBUGP("CB_reset done\n");
/* return a result code based on the result of the control
message */
return SUCCESS;
}
! int mcr_init(struct us_data *us) {
int result;
int pipe;
=== END OF DIFF ===
> Regarding other things - I can not tell you - I smoked my Phison
> when putting CF card with too much force - I am waiting for
> replacement unit.
>
> BR,
>
> Jacek
>
> P.S. Where did you get yours and for how much ?
> I bought mine for $29 at ubid and I want to get one for my borther
> but they do not have them any more. It is a nice toy.
It really is nice and small (only missing the Sony Memory Stick
capability, but that is marginal at least for me). I got my unit from
Tokyo/Japan with my frend when he came to visit his old home country :-)
The shop was http://www.asianetwork.co.jp but I somehow doubt that you
would buy it from there (it was not as cheap as $29).
Thanks again.
++Tero
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-users
