On Wed, 10 Mar 2004, Malcolm Blaney wrote:

> I'm happy to say usb no longer hangs on my single board computer! I

Great!

> thought I'd try diffing the uhci code from the kernel we had working,
> (2.4.18) and kernels that don't (so far 2.4.23 and 2.4.24). I got down
> to _one_ line causing the problem:
>
> uhci->fsbr = 0;   ...in alloc_uhci().
>
> Which was of course added in 2.4.19. I removed the line, since it's not
> in 2.4.18, and all the devices I had trouble with worked. Is this worth
> posting to the dev list? Can someone tell me the effect of setting fsbr
> to 0?

Strange. In 2.4.x uhci is just kmalloc'ed at that point, so, it must be
initialised. Also, I guess, you didn't test this "fix" under 2.6 - there
the whole struct is initialised to 0 with memset(). So, although, it is an
important observation, it is unlikely to be the correct fix. Yes, please
do report this to usb-devel. And, please, put "UHCI" in the subject line,
when you do this:-)

Thanks
Guennadi
---
Guennadi Liakhovetski




-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-users

Reply via email to