Sheesh, I was wondering about this at 530am in bed
this morning. I was going to double-check again
today. However, I think that we are talking about
2 different occurrences of strings.
Here's what Matt asked:
> (2) Does anyone know why we're not seeing the "OHCI Root Hub" string in
> the output? Did that patch (to identify virtual root hubs) not make it
> into the kernel?
I replied to when the strings are printed to the console or
kernel log, not whether they show up in /proc/bus/usb/devices.
And it looks to me like they are only printed #ifdef
CONFIG_USB_DEBUG, but you could still prove me wrong.
BTW, where do you find pre6? I didn't see it.
Patch applied. Thanks.
~Randy
___________________________________________________
|Randy Dunlap Intel Corp., DAL Sr. SW Engr.|
|randy.dunlap.at.intel.com 503-696-2055|
|NOTE: Any views presented here are mine alone |
|and may not represent the views of my employer. |
|_________________________________________________|
> From: Greg KH [mailto:[EMAIL PROTECTED]]
>
> On Tue, Apr 11, 2000 at 12:02:10PM -0700, Dunlap, Randy wrote:
> > No. Mfr, Product, and SerialNumber strings for any device
> > are only printed ifdef #CONFIG_USB_DEBUG.
>
> Um, that's not correct. I'm running 2.3.99-pre6 right now, with
> CONFIG_USB_DEBUG off and I have the Mfr, Product, and Serial number
> strings in /proc/bus/usb/devices. If you take a look at devices.c
> there's no checking for CONFIG_USB_DEBUG when it spits out these
> strings.
>
> I think they always should be there anyway. It allows some
> semi-popular
> userspace tools to allow the user to see what devices they
> actually have
> without having to keep a huge product database.
>
> So I vote that we keep the code the way it is right now for these
> strings (no patch attached :)
>
> greg k-h
> [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]