Matti et al,

I'll change keybdev.c to use the proper arch-type checking
based on your comments and looking thru MANY other source files
(but yours are correct IMO).


~Randy


> > > keybdev.c: In function `keybdev_event':
> > > keybdev.c:136: warning: implicit declaration of function 
> `emulate_raw'
> > > 
> > >   A declaration inclusion missing somewhere.
> > 
> > This one looks odd to me.  emulate_raw() is arch-dependent and
> > is defined 2 times before line 136.  One time is for
> > #if defined(CONFIG_X86) || defined(CONFIG_IA64) || \
> >   defined(CONFIG_ALPHA) || defined(CONFIG_MIPS)
> > 
> > and the other one is for
> > #elif defined(CONFIG_ADB_KEYBOARD)
> > 
> > So are you on an Alpha but CONFIG_ALPHA is not defined, or what?
> > Can you try to explain this?
> 
>       Proper subtest for this is:  defined(__alpha__)
>       (  and   defined(__mips__) -- I think  )
> 
>       While   arch/i386/config.in   file begins with
>               define_bool CONFIG_X86 y
>       same isn't true for arch/alpha/config.in, nor for
>       mips*, sparc*, ppc or m68k.
>       (IBM i390 isn't yet folded into 2.3 tree, so I can't say
>        where it stands -- not that it has uses for USB...)
> 
>       ARM seems to have  "CONFIG_ARM"
>       IA64 seems to have "CONFIG_IA64"
>       Super-H seems to have "CONFIG_SUPERH"


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to