On Mon, Nov 25, 2013 at 07:49:01PM -0500, Santosh Shilimkar wrote: > On Monday 25 November 2013 03:39 PM, Felipe Balbi wrote: > > Hi, > > > > [...] > > > > >> + kdwc3_dma_mask = dma_get_mask(dev); > >> + dev->dma_mask = &kdwc3_dma_mask; > >> + > >> + error = kdwc3_enable(kdwc); > > > > I would drop this function and just add your clk_prepare() here, then > > move clk_enable()/clk_disable() to ->runtime_resume/->runtime_suspend() > > respectively. Then you could just call pm_runtime_get_sync() when you > > need to access your registers and pm_runtime_put() when you want to drop > > the clock reference. > > > > this will even make PM implementation a lot easier for you going > > forward. > > > Just to make the PM runtime part clear, there are few issues with PM > core clock layer [1], hence drivers is using clock layer. Its trivial > to update the driver though once the issue is sorted out. > > Meanwhile driver development continue to be with clock calls.
I don't mind having those clock calls, just suggested a different placement for them. -- balbi
signature.asc
Description: Digital signature
