On Tue, Jan 27, 2015 at 05:42:02PM -0200, Fabio Estevam wrote:
> On Tue, Jan 27, 2015 at 12:16 PM, Fabio Estevam <feste...@gmail.com> wrote:
> > On Tue, Jan 27, 2015 at 11:37 AM,  <robert.jarz...@free.fr> wrote:
> >
> >> Is in the right node, ie. the node that has compatible == "usb-nop-xceiv" ?
> >
> > Yes, it is correct since this commit:
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/arch/arm/boot/dts/imx51-babbage.dts?id=7a9f0604bd56936b2b18f49824e0e392dc7878c3
> 
> This is the patch I have applied:
> 
> --- a/drivers/usb/phy/phy-generic.c
> +++ b/drivers/usb/phy/phy-generic.c
> @@ -218,11 +218,13 @@ int usb_phy_gen_create_phy(struct device *dev, struct 
> usb_
>                         clk_rate = 0;
> 
>                 needs_vcc = of_property_read_bool(node, "vcc-supply");
> -               nop->gpiod_reset = devm_gpiod_get(dev, "reset-gpios");
> +               nop->gpiod_reset = devm_gpiod_get_optional(dev, "reset");
> +               if (!nop->gpiod_reset)

wrong test, you should use IS_ERR(), NULL is a valid gpio descriptor.

-- 
balbi

Attachment: signature.asc
Description: Digital signature

Reply via email to