The forcing of device mode is not needed in the gadget init. This is
already taken care of in the probe just before this is called.

Signed-off-by: John Youn <johny...@synopsys.com>
---
 drivers/usb/dwc2/gadget.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index ba56c2d..4e9fc92 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -3531,19 +3531,6 @@ int dwc2_gadget_init(struct dwc2_hsotg *hsotg, int irq)
        else if (hsotg->dr_mode == USB_DR_MODE_PERIPHERAL)
                hsotg->op_state = OTG_STATE_B_PERIPHERAL;
 
-       /*
-        * Force Device mode before initialization.
-        * This allows correctly configuring fifo for device mode.
-        */
-       __bic32(hsotg->regs + GUSBCFG, GUSBCFG_FORCEHOSTMODE);
-       __orr32(hsotg->regs + GUSBCFG, GUSBCFG_FORCEDEVMODE);
-
-       /*
-        * According to Synopsys databook, this sleep is needed for the force
-        * device mode to take effect.
-        */
-       msleep(25);
-
        dwc2_core_reset(hsotg);
        ret = dwc2_hsotg_hw_cfg(hsotg);
        if (ret) {
@@ -3553,9 +3540,6 @@ int dwc2_gadget_init(struct dwc2_hsotg *hsotg, int irq)
 
        dwc2_hsotg_init(hsotg);
 
-       /* Switch back to default configuration */
-       __bic32(hsotg->regs + GUSBCFG, GUSBCFG_FORCEDEVMODE);
-
        hsotg->ctrl_buff = devm_kzalloc(hsotg->dev,
                        DWC2_CTRL_BUFF_SIZE, GFP_KERNEL);
        if (!hsotg->ctrl_buff) {
-- 
2.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to