On Sun, 2016-11-06 at 23:31 +0100, Ladislav Michl wrote:
> On Sun, Nov 06, 2016 at 10:30:02PM +0100, Oliver Neukum wrote:
> > Hi,
> >
> > almost. Two issues left with this section.
> >
> > 1. It makes no sense to check the results of usb_clear_halt()
> > If it fails, we cannot do anything sensible. We have to restart
> > IO and hope for the best. Not doing it that way risks introducing
> > a regression.
> >
> > 2. usb_autopm_put_interface() must be after acm_submit_read_urbs()
> > because the URBs are to be killed when the device is suspended.
> >
> > And on a related note:
> >
> > 3. The device may be reset externally before the work queue
> > is executed. pre_reset() needs to clear the flag EVENT_RX_STALL.
>
> Hi,
>
> thanks for feedback. Here's an update:
This is looking good. Please resend so Greg can pick it up.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
