On Fri, May 05, 2017 at 05:30:16PM +0200, Anthony Mallet wrote:
> Commit 557aaa7ffab6 ("ft232: support the ASYNC_LOW_LATENCY
> flag") enables unprivileged users to set the FTDI latency timer,
> but there was a logic flaw that skipped sending the corresponding
> USB control message to the device.
> 
> Signed-off-by: Anthony Mallet <anthony.mal...@laas.fr>
> ---
>  drivers/usb/serial/ftdi_sio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git drivers/usb/serial/ftdi_sio.c drivers/usb/serial/ftdi_sio.c

How did you generate this one? The white-space issue is gone, but now
it's a "p0" patch again (without the root directory in the paths) so
checkpatch complains and it does not apply using git am (with the normal
settings anyway).

Again, I can fix this up unless you prefer to respin. We have until the
end of the merge window to get it right. :)

> index d38780f..0e634c1 100644
> --- drivers/usb/serial/ftdi_sio.c
> +++ drivers/usb/serial/ftdi_sio.c
> @@ -1527,9 +1527,9 @@ static int set_serial_info(struct tty_struct *tty,
>                                       (new_serial.flags & ASYNC_FLAGS));
>       priv->custom_divisor = new_serial.custom_divisor;
>  
> +check_and_exit:
>       write_latency_timer(port);
>  
> -check_and_exit:
>       if ((old_priv.flags & ASYNC_SPD_MASK) !=
>            (priv->flags & ASYNC_SPD_MASK)) {
>               if ((priv->flags & ASYNC_SPD_MASK) == ASYNC_SPD_HI)

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to