On Wed, 2019-05-29 at 17:39 +0300, Kalle Valo wrote: > Luca Coelho <[email protected]> writes: > > > From: Shahar S Matityahu <[email protected]> > > > > Read fseq info from FW registers and print it upon fw assert. > > The print is needed since the fseq version coming from the TLV might > > not be the actual version that is used. > > > > Signed-off-by: Shahar S Matityahu <[email protected]> > > Signed-off-by: Luca Coelho <[email protected]> > > [...] > > > +void iwl_fw_error_print_fseq_regs(struct iwl_fw_runtime *fwrt) > > +{ > > + struct iwl_trans *trans = fwrt->trans; > > + unsigned long flags; > > + int i; > > + struct { > > + u32 addr; > > + const char *str; > > + } fseq_regs[] = { > > + FSEQ_REG(FSEQ_ERROR_CODE), > > + FSEQ_REG(FSEQ_TOP_INIT_VERSION), > > + FSEQ_REG(FSEQ_CNVIO_INIT_VERSION), > > + FSEQ_REG(FSEQ_OTP_VERSION), > > + FSEQ_REG(FSEQ_TOP_CONTENT_VERSION), > > + FSEQ_REG(FSEQ_ALIVE_TOKEN), > > + FSEQ_REG(FSEQ_CNVI_ID), > > + FSEQ_REG(FSEQ_CNVR_ID), > > + FSEQ_REG(CNVI_AUX_MISC_CHIP), > > + FSEQ_REG(CNVR_AUX_MISC_CHIP), > > + FSEQ_REG(CNVR_SCU_SD_REGS_SD_REG_DIG_DCDC_VTRIM), > > + FSEQ_REG(CNVR_SCU_SD_REGS_SD_REG_ACTIVE_VDIG_MIRROR), > > + }; > > Can fseq_regs be static const?
Yes, they can. Can we send a fix for -next? Shahar, can you make this change and send for internal review, please? -- Cheers, Luca.
