> -----Original Message----- > From: Bruce Ashfield <bruce.ashfi...@gmail.com> > Sent: Friday, June 14, 2024 8:53 PM > To: Li, Meng <meng...@windriver.com> > Cc: linux-yocto@lists.yoctoproject.org > Subject: Re: [linux-yocto]: [kernel/kernel-rt]: usb: dwc3: core: remove lock > of > otg mode during gadget suspend/resume to avoid deadlock > > CAUTION: This email comes from a non Wind River email account! > Do not click links or open attachments unless you recognize the sender and > know the content is safe. > > On Thu, Jun 13, 2024 at 8:16 PM Li, Meng <meng...@windriver.com> wrote: > > > > > > > > > -----Original Message----- > > > From: Bruce Ashfield <bruce.ashfi...@gmail.com> > > > Sent: Friday, June 14, 2024 3:24 AM > > > To: Li, Meng <meng...@windriver.com> > > > Cc: linux-yocto@lists.yoctoproject.org > > > Subject: Re: [linux-yocto]: [kernel/kernel-rt]: usb: dwc3: core: > > > remove lock of otg mode during gadget suspend/resume to avoid > > > deadlock > > > > > > CAUTION: This email comes from a non Wind River email account! > > > Do not click links or open attachments unless you recognize the > > > sender and know the content is safe. > > > > > > In message: [linux-yocto]: [kernel/kernel-rt]: usb: dwc3: core: > > > remove lock of otg mode during gadget suspend/resume to avoid > > > deadlock on 13/06/2024 Meng Li wrote: > > > > > > > From: Limeng <meng...@windriver.com> > > > > > > > > Hi Bruce, > > > > > > > > This patch is used to fix deadlock issues when testing > > > > suspend/resume. I will > > > send it to mainline upstream in later. > > > > So, could you please help merge these patches into linux-ycoto > > > > kernel in > > > advance, both below 2 branchs? > > > > v6.6/standard/nxp-sdk-6.6/nxp-soc > > > > v6.6/standard/preempt-rt/nxp-sdk-6.6/nxp-soc > > > > > > Given the response of upstream, I'll wait until you've replied and > > > an agreed upon solution is acheived. > > > > > > > Ok! I agree your advice, wait for the upstream response from USB > maintainer, and then improve my patch. > > I can reproduce this issue on NXP platforms using usb dwc3 driver, for > > example, ls1028. And I also verify this patch, suspend/resume feature works > fine with it. > > I think maybe it needs a long period to review this patch in upstream > community, and then accept it finally. Maybe it is not accepted by upstream in > worse case. > > So, is it possible to merge this patch into NXP branch, not standard/base > branch in advance? In this way, it will not affect other BSP. > > > > I haven't checked yet today for any more follow ups on the patch upstream, > but let's give it a few more days. > > I definitely don't need the patch accepted upstream to merge it, but if we can > at least hear that the approach is generally correct from the maintainers, I'm > happy to merge the work in progress patch to the nxp branches. >
I got response from usb maintainer. He ACK Xu Yang's patch that is similar with mine, but miss to remove the lock in dwc3_resume_common(). So, maintainer let me send patch again. I will improve the commit log, and then sent patch to you and mainline at the same time. https://lore.kernel.org/lkml/2024061313-october-sniff-5b0c@gregkh/t/ thanks, Limeng > Bruce > > > Thanks, > > LImeng > > > > > Bruce > > > > > > > > > > > diffstat info as below: > > > > > > > > core.c | 6 ------ > > > > 1 file changed, 6 deletions(-) > > > > > > > > > > > > thanks, > > > > Limeng > > > > -- > - Thou shalt not follow the NULL pointer, for chaos and madness await thee at > its end > - "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14051): https://lists.yoctoproject.org/g/linux-yocto/message/14051 Mute This Topic: https://lists.yoctoproject.org/mt/106647367/21656 Group Owner: linux-yocto+ow...@lists.yoctoproject.org Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
