On Sat, Nov 9, 2013 at 9:49 AM, Bruce Ashfield <bruce.ashfi...@windriver.com
> wrote:
> On 11/7/2013, 8:13 PM, Paul Butler wrote:
>
>> From: John Jacques <john.jacq...@lsi.com>
>>
>> Signed-off-by: John Jacques <john.jacq...@lsi.com>
>> ---
>> drivers/net/ethernet/lsi/lsi_acp_mdio.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/lsi/lsi_acp_mdio.c
>> b/drivers/net/ethernet/lsi/lsi_acp_mdio.c
>> index 04c224c..18aaba1 100644
>> --- a/drivers/net/ethernet/lsi/lsi_acp_mdio.c
>> +++ b/drivers/net/ethernet/lsi/lsi_acp_mdio.c
>> @@ -98,6 +98,11 @@ acp_mdio_read(unsigned long address, unsigned long
>> offset,
>> *value = (unsigned short)(command & 0xffff);
>> spin_unlock_irqrestore(&mdio_lock, flags);
>>
>> +#if 0
>> + printk("%s - Read 0x%x from 0x%x register 0x%x\n",
>> + __FUNCTION__, *value, address, offset);
>> +#endif
>> +
>> return 0;
>> }
>> EXPORT_SYMBOL(acp_mdio_read);
>> @@ -150,6 +155,11 @@ acp_mdio_write(unsigned long address, unsigned long
>> offset,
>>
>> spin_unlock_irqrestore(&mdio_lock, flags);
>>
>> +#if 0
>>
>
> These *really* need to be controlled by a define, or Kconfig that controls
> a #define.
>
> Leaving #if 0 code around the tree is bad form.
>
> The #if 0 code was removed in a later patch in this series. Actually, this
file was touched again several times in this series. This is also true of
other patches with dead code removal issues.
In some cases I tried to squash the cleanup together with a change, but I
see other comments discouraging that approach. I think we are pretty stable
at the tip, but it's pretty ugly how we got there. What is preferred?
Squash later cleanup into this patch? (And other similar issues.)
Paul
> Bruce
>
> + printk("%s - Wrote 0x%x to 0x%x register 0x%x\n",
>> + __FUNCTION__, value, address, offset);
>> +#endif
>> +
>> return 0;
>> }
>> EXPORT_SYMBOL(acp_mdio_write);
>>
>>
>
_______________________________________________
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto
