Hi again,
Just nitpicking here:
Le 2013-04-11 13:51, Ralph Droms a écrit :
> Stateless decompression mode 3 combines the MAC address from the MAC
> header
> with link-local prefix FE80::/64 to reconstruct the original IPv6
> address.
> This patch corrects comments, variable llconf and
> lowpan_uncompress_addr
> to be compatible with RFC 4644.
>
> Signed-off-by: Ralph Droms <rdr...@cisco.com>
> ---
> net/ieee802154/6lowpan.c | 50
> +++++++++++++++++++++++++++------------------
> 1 files changed, 30 insertions(+), 20 deletions(-)
>
> diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
> index 55e1fd5..a7bac63 100644
> --- a/net/ieee802154/6lowpan.c
> +++ b/net/ieee802154/6lowpan.c
> @@ -68,32 +68,32 @@ static const u8 lowpan_ttl_values[] = {0, 1, 64,
> 255};
> static LIST_HEAD(lowpan_devices);
>
> /*
> - * Uncompression of linklocal:
> + * Uncompression of stateless unicast:
> * 0 -> 16 bytes from packet
> * 1 -> 2 bytes from prefix - bunch of zeroes and 8 from packet
> * 2 -> 2 bytes from prefix - zeroes + 2 from packet
> - * 3 -> 2 bytes from prefix - infer 8 bytes from lladdr
> + * 3 -> 2 bytes from prefix - IID == MAC
IID is derived from MAC but is not equal to the MAC (with the whole u/g
bit flipping business). You might want to change your comment to reflect
that.
> * NOTE: => the uncompress function does change 0xf to 0x10
> * NOTE: 0x00 => no-autoconfig => unspecified
> */
> -static const u8 lowpan_unc_llconf[] = {0x0f, 0x28, 0x22, 0x20};
> +static const u8 lowpan_unc_slconf[] = {0x0f, 0x28, 0x22, 0x20};
>
> /*
> * Uncompression of ctx-based:
> * 0 -> 0 bits from packet [unspecified / reserved]
> * 1 -> 8 bytes from prefix - bunch of zeroes and 8 from packet
> * 2 -> 8 bytes from prefix - zeroes + 2 from packet
> - * 3 -> 8 bytes from prefix - infer 8 bytes from lladdr
> + * 3 -> 8 bytes from prefix - IID == MAC
Probably the same thing here.
[...]
> - pr_debug("dest: stateless compression\n");
> + pr_debug("stateless compression\n");
I think it would be better for the comment to be "stateless destination
compression\n" (perhaps this is what you intended to write, judging from
your previous comments).
Hope it helps.
Regards,
Tony
------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
