On 07.01.2008 12:21, Torsten Duwe wrote: > On Sunday 06 January 2008, Carl-Daniel Hailfinger wrote: > > >> This is a much needed simplification and readability improvement. Thanks! >> Generated code seems to be unchanged. >> >> If you drop the #undef lines (or explain why we absolutely need them), >> you can take the ack from below. >> > > I consider it good practise to undef such readability macros as soon as they > are not needed any more, like freeing unused memory. But I really have no > strong opinion about them, no problem. >
OK, that is a good reason. >> Acked-by: Carl-Daniel Hailfinger <[EMAIL PROTECTED]> >> > > Thanks, revision 3035. > >> Bonus points if you manage to convert all mptable.c files for MCP55 (or >> even, if that task is not too daring, all mptable.c files). >> > > You mean something like perl -pe > s:smp_write_intsrc\(mc,\s*mp_INT,\s*MP_IRQ[^,]*,\s*bus_isa\s*,(([^,]*),[^,]*, > ([^)]*)):ISA_INT($2, $3):g; > and so on? Turn it into a full-blown script and run it per board? > Maybe. > Yes, that would be cool. However, the needed macros even differ for different mcp55 boards, so scripted replacement may need a human to look over the results. Regards, Carl-Daniel -- linuxbios mailing list linuxbios@linuxbios.org http://www.linuxbios.org/mailman/listinfo/linuxbios