On 12.01.2008 01:58, Torsten Duwe wrote: > On Saturday 12 January 2008, Carl-Daniel Hailfinger wrote: > >> After configuring the PLL registers on Geode LX, we have to reset the >> processor. However, nothing in the log tells the user why the processor >> is being reset. >> > > >> + printk(BIOS_INFO, "Resetting the processor after PLL " >> + "configuration for the changes to take effect\n"); >> /* "Reset the chip" value */ >> > > It shouldn't be BIOS_INFO. Resetting the machine is as fundamental as can be, > so always tell this news if someone is listening (-> BIOS_EMERG). IMHO a few > stars might be appropriate as well, but that's a matter of taste. Besides > that >
Sorry, I saw your mail too late. I agree that it should have a high level, but since almost all messages in v3 are BIOS_DEBUG and even the first "LinuxBIOS v3.0.0 starting" is BIOS_INFO, I thought BIOS_INFO would be OK. BIOS_EMERG is a bit strong because every cold boot will trigger that code path by design. Someone needs to go through all those printk() and decide which level is appropriate for each message. > Acked-by: Torsten Duwe <[EMAIL PROTECTED]> > Thanks! Regards, Carl-Daniel -- linuxbios mailing list linuxbios@linuxbios.org http://www.linuxbios.org/mailman/listinfo/linuxbios
