On 10/2/07, Peter Korsgaard <[EMAIL PROTECTED]> wrote:
> >>>>> "Grant" == Grant Likely <[EMAIL PROTECTED]> writes:
> Grant> + pr_debug("uartlite: calling platform_driver_register()\n");
> Grant> + if ((ret = platform_driver_register(&ulite_platform_driver))
> != 0)
>
> I prefer to not have assignments in the if ().
Already fixed in v3
> Are all the pr_debug necessary? It looks quite messy.
Maybe messy, but *very* useful. Looks prettier in the v3 version with
the assignment and if() on separate lines.
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
[EMAIL PROTECTED]
(403) 399-0195
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
