Hi Paul & Ben,
I am trying to get hotplug memory remove working on ppc64.
In order to verify a given memory region, if its valid or not -
current hotplug-memory patches used /proc/iomem. On IA64 and
x86-64 /proc/iomem shows all memory regions.
I am wondering, if its acceptable to do the same on ppc64 also ?
Otherwise, we need to add arch-specific hooks in hotplug-remove
code to be able to do this.
Please comment. Here is the half-cooked patch I used to verify
the hotplug-memory-remove on ppc64.
Thanks,
Badari
---
arch/powerpc/mm/numa.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
Index: linux-2.6.23-rc8/arch/powerpc/mm/numa.c
===================================================================
--- linux-2.6.23-rc8.orig/arch/powerpc/mm/numa.c 2007-10-02
10:16:42.000000000 -0700
+++ linux-2.6.23-rc8/arch/powerpc/mm/numa.c 2007-10-02 10:17:05.000000000
-0700
@@ -587,6 +587,22 @@ static void __init *careful_allocation(i
return (void *)ret;
}
+static void add_regions_iomem()
+{
+ int i;
+ struct resource *res;
+
+ for (i = 0; i < lmb.memory.cnt; i++) {
+ res = alloc_bootmem_low(sizeof(struct resource));
+
+ res->name = "System RAM";
+ res->start = lmb.memory.region[i].base;
+ res->end = res->start + lmb.memory.region[i].size - 1;
+ res->flags = IORESOURCE_MEM;
+ request_resource(&iomem_resource, res);
+ }
+}
+
static struct notifier_block __cpuinitdata ppc64_numa_nb = {
.notifier_call = cpu_numa_callback,
.priority = 1 /* Must run before sched domains notifier. */
@@ -650,6 +666,8 @@ void __init do_init_bootmem(void)
free_bootmem_with_active_regions(nid, end_pfn);
+ add_regions_iomem();
+
/* Mark reserved regions on this node */
for (i = 0; i < lmb.reserved.cnt; i++) {
unsigned long physbase = lmb.reserved.region[i].base;
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
