On Mon, 2007-10-15 at 17:28 +1000, Benjamin Herrenschmidt wrote:
> This adds the low level irq tracing hooks to the powerpc architecture
> needed to enable full lockdep functionality
> 
> Some rework from Johannes initial version, removing the asm trampoline that
> isn't needed (thus improving perfs) and fixing a couple of bugs such as
> incorrect initial preempt_count on the softirq alternate stack.

Cool. I always wanted to look into seeing if I could remove that but
never got around to it. Thanks!


> --- linux-work.orig/include/asm-powerpc/irqflags.h    2007-10-15 
> 17:10:12.000000000 +1000
> +++ linux-work/include/asm-powerpc/irqflags.h 2007-10-15 17:11:09.000000000 
> +1000
 
>  /*
> - * Do the CPU's IRQ-state tracing from assembly code. We call a
> - * C function, so save all the C-clobbered registers:
> + * Most of the CPU's IRQ-state tracing is done from assembly code; we
> + * have to call a C function so call a wrapper that saves all the
> + * C-clobbered registers.
>   */

That comment is now wrong, it should probably be removed.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to