> -----Original Message----- > From: Grant Likely [mailto:[EMAIL PROTECTED] > Sent: Thursday, October 18, 2007 10:23 AM > To: linuxppc-dev@ozlabs.org; Stephen Neuendorffer; Wolfgang > Reissnegger; Leonid; [EMAIL PROTECTED]; Josh > Boyer; Arnd Bergmann > Subject: [PATCH v3] Device tree bindings for Xilinx devices > > From: Grant Likely <[EMAIL PROTECTED]> > > Signed-off-by: Grant Likely <[EMAIL PROTECTED]>
Acked-by: Stephen Neuendorffer <[EMAIL PROTECTED]> This is good enough for the moment, and it reflects the best we can do right now... But: > + (parameter#): C_* parameters from system.mhs. The C_ > prefix is > + dropped from the parameter name, the > name is converted > + to lowercase and all underscore '_' > characters are > + converted to dashes '-'. Unfortunately, xparameters don't follow this exactly, particularly for the 'multiple logical devices' case... Maybe it's worth adding something like: "For simple devices, the parameter name can be formed by:" In any event, this should essentially document what the mechanism for generating the device trees actually does... Have you updated gen_mhs_devtree.py to reflect all this? > + Typically, the compatible list will include the exact IP > core version > + followed by an older IP core version which implements the same > + interface or any other device with the same interface. This seems to be awkward, since it means that the tree *and* the driver will likely have long lists of compatible types. In the driver, this is hard to maintain, and in the device tree we don't have an easy way of knowing exactly what is compatible and what isn't anyway... It seems better to me to have the compatible list include the exact type (e.g. xilinx,opb-uartlite-1.00.b) and a generic compatibility class (e.g. xilinx,uartlite), and for the drivers to essentially define the gross compatibility classes. Then the driver only has an of_match with: .compatible = "xilinx,uartlite" Steve _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev