Hi Will, Just a trivial comment ...
On Mon, 29 Oct 2007 13:32:19 -0500 Will Schmidt <[EMAIL PROTECTED]> wrote:
>
> +static inline int esids_match(unsigned long addr1, unsigned long addr2)
> +{
> + int esid_1t_count;
> +
> + /* System is not 1T segment size capable. */
> + if (!cpu_has_feature(CPU_FTR_1T_SEGMENT))
> + return (GET_ESID(addr1) == GET_ESID(addr2));
> +
> + esid_1t_count = (((addr1>>SID_SHIFT_1T)!=0) +
> ((addr2>>SID_SHIFT_1T)!=0));
Please use spaces around binary operators (as you have elsewhere). Even
if it pushes the line slightly over 80 characters ...
--
Cheers,
Stephen Rothwell [EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpLsYJ7RHmtU.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list [email protected] https://ozlabs.org/mailman/listinfo/linuxppc-dev
