Olof Johansson wrote: > On Wed, Oct 31, 2007 at 10:08:05AM +1100, David Gibson wrote: >> On Tue, Oct 30, 2007 at 07:56:50PM +0300, Valentine Barshak wrote: >>> PowerPC 440GRx Rainier DTS. >> [snip] >>> + SDRAM0: sdram { >>> + device_type = "memory-controller"; >> How many times do we need to say it... >> >> Don't make up random device_type values. This does not belong here. > > Maybe there should be something like checkpatch.pl that warns about > these kinds of things so people can check for it without getting flamed > first. :-) > > Lots of people base their dts'es on other ones, so until the kernel has > bene clean a while, this will happen all the time. I'm saying "a while" > because people tend to base them on what's fresh when they do the work, > but it might take a few months between then and when they post, etc.
Yep, It's been copy-pasted from sequoia.dts. Sorry for that, I'll rmove both. Thanks, Valentine. > > > -Olof _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev