Sylvain Munaut wrote: > > Valentine Barshak wrote: > >> Rework ohci-ppc-of driver to use big-endian property instead of > >> ohci-be/ohci-le compatible strings. Also remove unnecessary > >> user-selectable USB_OHCI_HCD_PPC_OF_LE/BE stuff, because > >> USB_OHCI_BIG_ENDIAN_DESC/MMIO should always be enabled for ppc > >> and USB_OHCI_LITTLE_ENDIAN is selected for USB_OHCI_HCD_PCI by default. > > I don't find those options useless. If you think the defauts are not the > best change them but I find these options relevant. You don't always want > the support for BE on PPC ... if the only controller you have is pci ... > or if you're on a soc that use little endian ...
USB_OHCI_LITTLE_ENDIAN and USB_OHCI_BIG_ENDIAN are useful and I don't see anyone wanting to remove them. However, if all of the chips supported by the ohci-ppc-of driver are big-endian, then USB_OHCI_HCD_PPC_OF_LE and USB_OHCI_HCD_PPC_OF_BE are not needed. Just select USB_OHCI_BIG_ENDIAN when the ohci-ppc-of driver is selected, in the same way that we always select USB_OHCI_LITTLE_ENDIAN when the ohci-pci driver is selected. -Dale _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
