On 11/5/07, Matt Sealey <[EMAIL PROTECTED]> wrote: > Jon Smirl wrote: > > > [EMAIL PROTECTED] { > > device_type = "i2c"; > > compatible = "mpc5200b-i2c\0mpc5200-i2c\0fsl-i2c"; > > cell-index = <1>; > > reg = <3d40 40>; > > interrupts = <2 10 0>; > > interrupt-parent = <&mpc5200_pic>; > > fsl5200-clocking; > > > > [EMAIL PROTECTED] { > > device_type = "rtc"; > > compatible = "epson,pcf8564"; > > reg = <51>; > > }; > > }; > > My only comment would be that the fsl5200-clocking property is > totally redundant. > > Drivers can look at the compatible property (mpc5200b-i2c and > mpc5200-i2c) to match up what special needs the driver may need. > Even if it was just fsl-i2c, it could/should be implicit that > this device is the onboard i2c and the parent node is ostensibly > going to be marked as an MPC52xx SoC.. or it can look for the > mpc5200-cdm node. There is no reason to invent a property just > so you can do a property search when it replaces code of the > same size to do a node or compatible search..
fsl5200-clocking is used to set FSL_I2C_DEV_CLOCK_5200 } else if (i2c->flags & FSL_I2C_DEV_CLOCK_5200) writeb(0x3f, i2c->base + MPC_I2C_FDR); else writel(0x1031, i2c->base + MPC_I2C_FDR); I can change it to remove fsl5200-clocking if someone can tell me if this is only needed on the mpc5200b. This driver also supports the MPC107/Tsi107/MPC8240/MPC8245 and MPC85xx/MPC8641. Do any of these other chips need fsl5200-clocking? -- Jon Smirl [EMAIL PROTECTED] _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev