On Thu, 2007-11-08 at 13:01 +0100, Johannes Berg wrote:
> I see nothing that this lock_kernel() actually protects against
> so remove it.
>
> Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
Acked-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
> ---
> drivers/macintosh/via-pmu.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> --- everything.orig/drivers/macintosh/via-pmu.c 2007-11-08
> 11:48:37.192845813 +0100
> +++ everything/drivers/macintosh/via-pmu.c 2007-11-08 11:48:48.292846681
> +0100
> @@ -33,7 +33,6 @@
> #include <linux/adb.h>
> #include <linux/pmu.h>
> #include <linux/cuda.h>
> -#include <linux/smp_lock.h>
> #include <linux/module.h>
> #include <linux/spinlock.h>
> #include <linux/pm.h>
> @@ -2436,7 +2435,6 @@ pmu_release(struct inode *inode, struct
> struct pmu_private *pp = file->private_data;
> unsigned long flags;
>
> - lock_kernel();
> if (pp != 0) {
> file->private_data = NULL;
> spin_lock_irqsave(&all_pvt_lock, flags);
> @@ -2450,7 +2448,6 @@ pmu_release(struct inode *inode, struct
>
> kfree(pp);
> }
> - unlock_kernel();
> return 0;
> }
>
>
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev
