Nicholas Piggin <npig...@gmail.com> writes: > On Tue, 09 Aug 2016 14:49:25 +1000 > Michael Ellerman <m...@ellerman.id.au> wrote: > >> Nicholas Piggin <npig...@gmail.com> writes: >> >> > diff --git a/arch/powerpc/kernel/vdso32/Makefile >> > b/arch/powerpc/kernel/vdso32/Makefile >> > index cbabd14..ae1f245 100644 >> > --- a/arch/powerpc/kernel/vdso32/Makefile >> > +++ b/arch/powerpc/kernel/vdso32/Makefile >> > @@ -39,14 +39,14 @@ $(obj)/%.so: $(obj)/%.so.dbg FORCE >> > $(call if_changed,objcopy) >> > >> > # assembly rules for the .S files >> > -$(obj-vdso32): %.o: %.S >> > +$(obj-vdso32): %.o: %.S FORCE >> > $(call if_changed_dep,vdso32as) >> > >> > # actual build commands >> > quiet_cmd_vdso32ld = VDSO32L $@ >> > - cmd_vdso32ld = $(CROSS32CC) $(c_flags) -Wl,-T $^ -o $@ >> > + cmd_vdso32ld = $(CROSS32CC) $(c_flags) -o $@ -Wl,-T$(filter >> > %.lds,$^) $(filter %.o,$^) >> > quiet_cmd_vdso32as = VDSO32A $@ >> > - cmd_vdso32as = $(CROSS32CC) $(a_flags) -c -o $@ $< >> > + cmd_vdso32as = $(CROSS32CC) $(a_flags) -o $@ -c $< >> >> Are the two changes above required, they aren't obviously related. > > The vdso32ld change is required because otherwise "FORCE" gets put on > the end of the command line. vdso32as... I think is not required. Want > a new version without it?
Yeah either without it or just explaining why it's needed in the change log. cheers