Hi Sean, On Fri, 11 Jan 2008 02:10:45 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote: > > Stephen Rothwell wrote: > > On Wed, 09 Jan 2008 15:19:13 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote: > > > >> No comments? I really thought I would get raked over the coals for this > >> one. > > > > Ah ha! A challenge! :-) > > > I hoped somebody would respond to that ;)
Glad to oblige.
> >> +static int pika_dtm_thread(void *fpga)
> >> +{
> >> + extern int ad7414_get_temp(int index);
> >
> > no externs in C code - put it in a header file.
>
> I didn't know where to put this extern. It is fairly specific to this
> driver, although a generic function... if that makes sense. It returns
> the exact contents of the register rather than doing any conversion.
>
> Any recommendations for a location gladly accepted.
I don't where that function is actually defined - I assume it is in one
of the other recent patch sets.
/me searches ...
/me reads "ad7414 driver" email ...
/me notes spaces missing there as well :-)
Tricky. You have something that can only be built in (pika_dtm_thread in
warp.c) calling something that might be a module ... I think you need to
think of a new way of organizing these pieces.
While I am looking, the return type of ioremap is "void __iomem *", so
you need to annotate your "fpga" variable appropriately and the parameter
to pika_dtm_thread.
> And below has all the above mentioned fixes, except the extern.
You seem to have forgotten some of the spaces after "if"s, "switch"s and
"while"s.
--
Cheers,
Stephen Rothwell [EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgp55h0LF512Z.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list [email protected] https://ozlabs.org/mailman/listinfo/linuxppc-dev
