Anshuman Khandual <khand...@linux.vnet.ibm.com> writes: > On 12/13/2016 07:34 PM, Aneesh Kumar K.V wrote: >> generic hugetlbfs can handle that condition correctly. With HPAGE_SHIFT = 0 > > Need to add some context here. "That condition" refers to something without > first mentioning it.
It is the conditinal statement that gets removed as part of this patch. The next line also explains what the generic code does for that condition. > >> we get >> [0.241333] hugetlbfs: disabling because there are no supported hugepage sizes >> >> bash-4.2# echo 30 > /proc/sys/vm/nr_hugepages >> bash: echo: write error: Operation not supported >> >> Fixes: "powerpc: get hugetlbpage handling more generic" > > Dont we need the commit SHA for the "Fixes" header ? When I wrote the patch, the commit was not upstream. Hence i didn't had an SHA1 to put there. -aneesh