On 2017/03/08 11:31AM, Masami Hiramatsu wrote: > On Wed, 8 Mar 2017 13:56:10 +0530 > "Naveen N. Rao" <naveen.n....@linux.vnet.ibm.com> wrote: > > > perf now uses an offset from _text/_stext for kretprobes if the kernel > > supports it, rather than the actual function name. As such, let's choose > > the LEP for powerpc ABIv2 so as to ensure the probe gets hit. Do it only > > if the kernel supports specifying offsets with kretprobes. > > Acked-by: Masami Hiramatsu <mhira...@kernel.org> > > This patch is OK. And I found that most of functions in sym-handling.c > are used only when libelf is supported. (e.g. probe-event.c itself > is not built when we have no libelf) > So, for the next cleanup, this file should not be compiled without > libelf.
There are still a few functions there which work without libelf. But, I agree that the file has far too many #ifdefs between ABIv2 and libelf. I will see if I can simplify this file. Thanks, Naveen