On Friday 18 January 2008, Jochen Friedrich wrote: > Directly include mpc885ads.h from mpc885ads_setup.c. Now we can get rid > of the arch dependent includes in mpc8xx.h.
Ah, very nice. How close are we to enabling an 8xx multiplatform build after this? > #ifdef CONFIG_8xx > > extern void mpc8xx_restart(char *cmd); > @@ -18,22 +20,9 @@ extern void mpc8xx_get_rtc_time(struct rtc_time *tm); > extern void mpc8xx_pics_init(void); > extern unsigned int mpc8xx_get_irq(void); > > #ifdef CONFIG_PCMCIA_M8XX > extern struct mpc8xx_pcmcia_ops m8xx_pcmcia_ops; > #endif > #endif /* CONFIG_8xx */ > #endif /* __CONFIG_8xx_DEFS */ You can also kill the #ifdef CONFIG_8xx and the #ifdef CONFIG_PCMCIA_M8XX, there is no point hiding extern declarations behind an #ifdef, but it has the disadvantage of causing unnecessary rebuilds if the configuration symbols change. Arnd <>< _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev